807 update dice and the relevant loss #1153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyli
force-pushed
the
807-flexible-dice-loss
branch
from
1153952 to
2227a07
Compare
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
wyli
force-pushed
the
807-flexible-dice-loss
branch
from
2227a07 to
db73f0d
Compare
Member
|
Looks good to me, @martaranzini ? |
Collaborator
|
Looks all good to me as well! Perhaps it could be worth adding a test case where the two smooth terms are different, say smooth_nr=0 and smooth_dr=1e-5? |
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
ericspod
approved these changes
Oct 28, 2020
wyli
added a commit
that referenced
this pull request
Nov 4, 2020
* update dice and the relevant loss Signed-off-by: Wenqi Li <wenqil@nvidia.com> * update based on the comments Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #807
Description
smooth_nr/smooth_drfor the numerators and denominatorsStatus
Ready
Types of changes
./runtests.sh --quick.make htmlcommand in thedocs/folder.