Skip to content

Conversation

@rijobro
Copy link
Contributor

@rijobro rijobro commented Nov 2, 2020

Fixes #1172.

Description

LLTM test shouldn't be run if code hasn't been compiled

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).

@rijobro rijobro requested a review from wyli November 2, 2020 11:52
@wyli
Copy link
Contributor

wyli commented Nov 2, 2020

perhaps we could have a skip_if_no_compile decorator, like

MONAI/tests/utils.py

Lines 29 to 32 in d0b6677

def skip_if_quick(obj):
is_quick = os.environ.get(quick_test_var, "").lower() == "true"
return unittest.skipIf(is_quick, "Skipping slow tests")(obj)

@rijobro
Copy link
Contributor Author

rijobro commented Nov 2, 2020

Good point, updated.

Signed-off-by: Rich <33289025+rijobro@users.noreply.github.com>
Signed-off-by: Rich <33289025+rijobro@users.noreply.github.com>
@wyli wyli merged commit e8b9dd0 into Project-MONAI:master Nov 2, 2020
@rijobro rijobro deleted the compiled_test branch November 11, 2020 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TestLLTM failure

2 participants