Skip to content

Conversation

@madil90
Copy link
Contributor

@madil90 madil90 commented Feb 27, 2020

Fixes #109 .

Description

Adds Flip transform. Tests coming soon.

Status

Work in progress

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or new feature that would cause existing functionality to change)
  • New tests added to cover the changes
  • Docstrings/Documentation updated

@madil90 madil90 requested review from ericspod and wyli February 27, 2020 21:40
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks -- will merge once a unit test is in place

@madil90 madil90 force-pushed the 109-spatial-flip branch from 6f10623 to 2b3ce01 Compare March 3, 2020 05:40
@madil90
Copy link
Contributor Author

madil90 commented Mar 3, 2020

@wyli added tests.

@madil90 madil90 changed the title Add spatial flip to transforms. 109-spatial-flip Mar 3, 2020
Copy link
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add comments inline.
Thanks.

Copy link
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now.
Thanks.

@Nic-Ma Nic-Ma merged commit ec57b73 into master Mar 4, 2020
@wyli wyli deleted the 109-spatial-flip branch May 21, 2020 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Port spatial flip/mirroring transform

5 participants