Skip to content

Conversation

@IsaacYangSLA
Copy link
Contributor

Signed-off-by: Isaac Yang isaacy@nvidia.com

Fixes #1252

Description

The local docker build step (local_docker in deploy) builds the monai:latest from Dockerfile. This PR is to push that image to dockerhub. The build failure seemed related to the load in dockerhub. Moving the build process to our runners can reduce load on dockerhub and the build failure.

The local_docker step takes about 4min20sec~5min, and adding this docker push step does not occupy GPU resources.

** Requiring to add credential (DOCKER_PW of projectmonai) to repo's secrets.
** This PR does docker logout immediately after docker push is done.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh --codeformat --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Isaac Yang <isaacy@nvidia.com>
Signed-off-by: Isaac Yang <isaacy@nvidia.com>
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@wyli wyli merged commit a7ef9d5 into Project-MONAI:master Nov 19, 2020
@IsaacYangSLA IsaacYangSLA deleted the docker_build_in_self_hosted_runner branch January 14, 2021 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docker image build fails frequently

2 participants