852 adds a timeout call decorator #1301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyli
force-pushed
the
852-expected-execution-time
branch
8 times, most recently
from
b789665 to
6bdf96f
Compare
Contributor
Author
|
/integration-test |
wyli
force-pushed
the
852-expected-execution-time
branch
2 times, most recently
from
670ba89 to
3405911
Compare
wyli
requested review from
Nic-Ma and
ericspod
and removed request for
Nic-Ma
Contributor
Author
|
/black |
Contributor
|
Hi @IsaacYangSLA , Could you please help review this PR to enhance our CICD? Thanks. |
Contributor
Author
|
Hi @Nic-Ma could you review it as well, this PR also added some testing logic for the integration tests you created earlier |
Contributor
|
OK, sure |
Nic-Ma
approved these changes
Dec 2, 2020
Contributor
Nic-Ma
left a comment
Nic-Ma
left a comment
There was a problem hiding this comment.
This overall feature looks good to me except some minor comments.
@IsaacYangSLA Is it expected in our CI / CD development plan for the test of execution time?
If you don't have any more comments, we will merge it later.
Thanks.
wyli
force-pushed
the
852-expected-execution-time
branch
from
dff4423 to
25623e7
Compare
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
wyli
force-pushed
the
852-expected-execution-time
branch
from
25623e7 to
ba88abb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wenqi Li wenqil@nvidia.com
fixes #852 fixes #927
Description
adds a test util for raising an exception if the execution time exceeds a threshold
Status
Ready
Types of changes
./runtests.sh --codeformat --coverage../runtests.sh --quick.make htmlcommand in thedocs/folder.