Skip to content

1330 Refine generate_spatial_bounding_box API #1336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wyli merged 7 commits into from
Dec 9, 2020
Merged

1330 Refine generate_spatial_bounding_box API #1336

wyli merged 7 commits into from
Dec 9, 2020

Conversation

@Nic-Ma
Copy link
Contributor

@Nic-Ma Nic-Ma commented Dec 9, 2020

Fixes #1330 .

Description

This PR combined compute_bounding_rect and generate_spatial_bounding_box APIs.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh --codeformat --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Dec 9, 2020

/black

wyli
wyli reviewed Dec 9, 2020
View reviewed changes
wyli
wyli reviewed Dec 9, 2020
View reviewed changes
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the quick pr, I put some comments inline

@Nic-Ma
[DLMED] update according to comments
c984e75 
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Dec 9, 2020

/black

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Dec 9, 2020

Hi @wyli ,

Thanks for your review.
I updated the PR according to your comments, could you please help review it again?

Thanks.

@Nic-Ma
[DLMED] add check for margin value
cc215b5 
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Dec 9, 2020 •
edited by wyli
Loading

/integration-test /black

wyli
wyli approved these changes Dec 9, 2020
View reviewed changes
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@wyli wyli merged commit 6b95e4d into Project-MONAI:master Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wyli wyli wyli approved these changes

@ericspod ericspod Awaiting requested review from ericspod

@atbenmurray atbenmurray Awaiting requested review from atbenmurray

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Combine compute_bounding_rect and generate_spatial_bounding_box

2 participants

@Nic-Ma @wyli