Skip to content

Conversation

@charliebudd
Copy link
Collaborator

Signed-off-by: charliebudd charles.budd@kcl.ac.uk

Addresses #1337.

Description

Adds a few easy to use function decorators which aim to give limited but accurate profiling information.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh --codeformat --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: charliebudd <charles.budd@kcl.ac.uk>
Signed-off-by: charliebudd <charles.budd@kcl.ac.uk>
Signed-off-by: charliebudd <charles.budd@kcl.ac.uk>
@charliebudd charliebudd requested review from ericspod and wyli December 10, 2020 12:21
Signed-off-by: charliebudd <charles.budd@kcl.ac.uk>
@wyli
Copy link
Contributor

wyli commented Dec 10, 2020

thanks, could you add an __all__ to profiling.py like this one

__all__ = [

and update the import commands in utils/__init__.py

from .module import *

Signed-off-by: charliebudd <charles.budd@kcl.ac.uk>
@wyli
Copy link
Contributor

wyli commented Dec 10, 2020

/black

monai-bot and others added 2 commits December 10, 2020 13:48
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@wyli wyli merged commit b9b8c83 into Project-MONAI:master Dec 10, 2020
@charliebudd charliebudd deleted the 1337-profiling-tools branch December 10, 2020 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants