Skip to content

Conversation

@IsaacYangSLA
Copy link
Contributor

@IsaacYangSLA IsaacYangSLA commented Dec 10, 2020

Signed-off-by: Isaac Yang isaacy@nvidia.com

Fixes # .

Description

This is to handle BraTS18 dataset label, which is different from MSD Brain.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh --codeformat --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

…et label

Signed-off-by: Isaac Yang <isaacy@nvidia.com>
@Nic-Ma
Copy link
Contributor

Nic-Ma commented Dec 13, 2020

Hi @IsaacYangSLA ,

Could you please help add a simple unit test for this transform? Then we can make sure further modification still works.
Thanks.

Copy link
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Thanks.

@wyli wyli merged commit 4911eb3 into Project-MONAI:master Dec 14, 2020
@IsaacYangSLA IsaacYangSLA deleted the add_custom_transform branch January 14, 2021 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants