Skip to content

Update hausdorff metric and surface distance #1351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wyli merged 10 commits into from
Dec 14, 2020
Merged

Update hausdorff metric and surface distance #1351

wyli merged 10 commits into from
Dec 14, 2020

Conversation

@yiheng-wang-nv
Copy link
Contributor

@yiheng-wang-nv yiheng-wang-nv commented Dec 11, 2020 •
edited
Loading

Signed-off-by: yiheng-wang-nv vennw@nvidia.com

Fixes #1290 .

Status

Work in progress

Types of changes

  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh --codeformat --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@yiheng-wang-nv
Update hausdorff metric
6f23f38 
Signed-off-by: yiheng-wang-nv <vennw@nvidia.com>
@yiheng-wang-nv
Update surface distance
3448fd3 
Signed-off-by: yiheng-wang-nv <vennw@nvidia.com>
@yiheng-wang-nv
fix reduction type error
31a6dfe 
Signed-off-by: yiheng-wang-nv <vennw@nvidia.com>
@yiheng-wang-nv
Copy link
Contributor Author

yiheng-wang-nv commented Dec 11, 2020

Will add the corresponding metric handlers later then a formal MR will be submitted

@Nic-Ma
Copy link
Contributor

Nic-Ma commented Dec 14, 2020

Hi @yiheng-wang-nv ,

We plan to tag for MONAI v0.4 release soon, could you please help update this PR for review?

Thanks.

@yiheng-wang-nv yiheng-wang-nv marked this pull request as ready for review December 14, 2020 13:03
@yiheng-wang-nv yiheng-wang-nv changed the title [WIP] Update hausdorff metric and surface distance Update hausdorff metric and surface distance Dec 14, 2020
@wyli
Copy link
Contributor

wyli commented Dec 14, 2020 •
edited
Loading

/integration-test /black

wyli added 2 commits December 14, 2020 18:50
@wyli
autofixes and typo fixes
2dc510a 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
fixes lgtm typos
876365f 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
wyli
wyli approved these changes Dec 14, 2020
View reviewed changes
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, all tests passed and changes tested locally

@wyli wyli merged commit dc5c3d4 into Project-MONAI:master Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wyli wyli wyli approved these changes

@Nic-Ma Nic-Ma Awaiting requested review from Nic-Ma

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update hausdorff_distance and surface_distance

3 participants

@yiheng-wang-nv @Nic-Ma @wyli