Skip to content

Conversation

@wyli
Copy link
Contributor

@wyli wyli commented Dec 15, 2020

Fixes #1346

  • simplified the api to use monai Convolution
  • move channelwise padding to simplelayers.py

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh --codeformat --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli force-pushed the 1346-enhance-highresnet branch from 0bea46c to 25ac87c Compare December 15, 2020 13:02
@wyli
Copy link
Contributor Author

wyli commented Dec 15, 2020

/black

Signed-off-by: monai-bot <monai.miccai2019@gmail.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli merged commit 0563a44 into Project-MONAI:master Dec 15, 2020
@wyli wyli deleted the 1346-enhance-highresnet branch April 28, 2021 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

highresnet; there is no need to pass the inplace input argument for all activations except ReLU

3 participants