Skip to content

Conversation

@charliebudd
Copy link
Collaborator

@charliebudd charliebudd commented Dec 16, 2020

Signed-off-by: charliebudd charles.budd@kcl.ac.uk

Fixes #1370 .

Description

Simply adds '.venv' to the list of ignores. It would be nice to use the VIRTUAL_ENV environment variable which I believe is accessable on linux and windows. However as we use a .cfg file I don't think it can be evaluated when the config is loaded.

I can use the environment variable by directly adding the ignore in runtests.sh however this then overwrites the ignores in the .cfg files

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh --codeformat --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: charliebudd <charles.budd@kcl.ac.uk>
@charliebudd charliebudd requested a review from wyli December 16, 2020 16:46
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@wyli wyli merged commit d8f6c20 into Project-MONAI:master Dec 16, 2020
@charliebudd charliebudd deleted the 1370-flake8-isort-ignore-update branch December 17, 2020 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Auto formatting includes '.venv' directory

2 participants