Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@ _Pull request early_

We encourage you to create pull requests early. It helps us track the contributions under development, whether they are ready to be merged or not. Change your pull request's title to begin with `[WIP]` until it is ready for formal review.

Please note that, as per PyTorch, MONAI uses American English spelling. This means classes and variables should be: normali**z**e, visuali**z**e, colo~~u~~r, etc.

### Preparing pull requests
To ensure the code quality, MONAI relies on several linting tools ([flake8 and its plugins](https://gitlab.com/pycqa/flake8), [black](https://github.com/psf/black), [isort](https://github.com/timothycrosley/isort)),
static type analysis tools ([mypy](https://github.com/python/mypy), [pytype](https://github.com/google/pytype)), as well as a set of unit/integration tests.
Expand Down
2 changes: 1 addition & 1 deletion monai/networks/blocks/acti_norm.py
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ def __init__(
super().__init__()

op_dict = {"A": None, "D": None, "N": None}
# define the normalisation type and the arguments to the constructor
# define the normalization type and the arguments to the constructor
if norm is not None:
if norm_dim is None and dropout_dim is None:
raise ValueError("norm_dim or dropout_dim needs to be specified.")
Expand Down
2 changes: 1 addition & 1 deletion monai/networks/layers/factories.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
is typically a type but can be any callable producing a layer object.

The factory objects contain functions keyed to names converted to upper case, these names can be referred to as members
of the factory so that they can function as constant identifiers. eg. instance normalisation is named `Norm.INSTANCE`.
of the factory so that they can function as constant identifiers. eg. instance normalization is named `Norm.INSTANCE`.

For example, to get a transpose convolution layer the name is needed and then a dimension argument is provided which is
passed to the factory function:
Expand Down
2 changes: 1 addition & 1 deletion monai/networks/layers/spatial_transforms.py
Original file line number Diff line number Diff line change
Expand Up @@ -518,7 +518,7 @@ def forward(
if spatial_size is not None:
dst_size = src_size[:2] + ensure_tuple(spatial_size)

# reverse and normalise theta if needed
# reverse and normalize theta if needed
if not self.normalized:
theta = to_norm_affine(
affine=theta, src_size=src_size[2:], dst_size=dst_size[2:], align_corners=self.align_corners
Expand Down
2 changes: 1 addition & 1 deletion monai/transforms/compose.py
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ class Compose(Randomizable, Transform):
set of functions must be called as if it were a sequence.

Example: images and labels
Images typically require some kind of normalisation that labels do not.
Images typically require some kind of normalization that labels do not.
Both are then typically augmented through the use of random rotations,
flips, and deformations.
Compose can be used with a series of transforms that take a dictionary
Expand Down
2 changes: 1 addition & 1 deletion monai/utils/enums.py
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ class Weight(Enum):
UNIFORM = "uniform"


class Normalisation(Enum):
class Normalization(Enum):
"""
See also:
- :py:class:`monai.networks.nets.ConvNormActi`
Expand Down
2 changes: 1 addition & 1 deletion tests/test_unet.py
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
(16, 3, 32, 64, 48),
]

TEST_CASE_4 = [ # 4-channel 3D, batch 16, batch normalisation
TEST_CASE_4 = [ # 4-channel 3D, batch 16, batch normalization
{
"dimensions": 3,
"in_channels": 4,
Expand Down