-
Notifications
You must be signed in to change notification settings - Fork 1.4k
1405 add bending energy loss #1408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
ac67c65 to
34fb746
Compare
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
wyli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, the style/format of this PR looks great, it's a really nice starting point. I put some comments about the actual logic. ideally we should have something general for different spatial dimensions, not just for spatial 3D
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
wyli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, I forgot to mention that perhaps rename gradient to spatial_gradient to avoid confusion?
also, do you want to put some acknowledgement in the docstring such asadapted from DeepRegNet? cc @YipengHu
Sounds good to have a reference to DeepReg, using either the paper or github URL. |
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
Fixes #1408 .
Description
Add bending energy loss useful for registration.
Status
Ready/Work in progress/Hold
Types of changes
./runtests.sh --codeformat --coverage../runtests.sh --quick.make htmlcommand in thedocs/folder.