1412 local normalized cross correlation #1415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
wyli
reviewed
Jan 7, 2021
Contributor
wyli
left a comment
wyli
left a comment
There was a problem hiding this comment.
many thanks! I put some minor comments inline
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
kate-sann5100
changed the title
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
mathpluscode
suggested changes
Jan 10, 2021
mathpluscode
left a comment
mathpluscode
left a comment
There was a problem hiding this comment.
Suggested some refactoring and raised errors should be covered in the tests.
But not sure if we need to mention potential errors in docstring, it'd be better to do so.
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
…elation' into 1412-local-normalized-cross-correlation
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
mathpluscode
approved these changes
Jan 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # 1412.
Description
A few sentences describing the changes proposed in this pull request.
Status
Ready/Work in progress/Hold
Types of changes
./runtests.sh --codeformat --coverage../runtests.sh --quick.make htmlcommand in thedocs/folder.