New simplelayer SavitzkyGolayFilter() and transform SavitzkyGolaySmooth() #1418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crnbaker
force-pushed
the
1155-savitzky-golay-kernel
branch
9 times, most recently
from
96a762c to
5b67b01
Compare
crnbaker
force-pushed
the
1155-savitzky-golay-kernel
branch
from
5b67b01 to
a4ef691
Compare
Signed-off-by: Christian Baker <christian.baker@kcl.ac.uk>
Signed-off-by: Christian Baker <christian.baker@kcl.ac.uk>
crnbaker
force-pushed
the
1155-savitzky-golay-kernel
branch
from
6248e34 to
4e4416a
Compare
…GolayFilter() simplelayer Signed-off-by: Christian Baker <christian.baker@kcl.ac.uk>
Signed-off-by: Christian Baker <christian.baker@kcl.ac.uk>
crnbaker
force-pushed
the
1155-savitzky-golay-kernel
branch
8 times, most recently
from
7f0f3c5 to
cda44a4
Compare
crnbaker
changed the title
wyli
reviewed
Jan 14, 2021
Contributor
wyli
left a comment
wyli
left a comment
There was a problem hiding this comment.
thank you! please see some minor comments inline
Signed-off-by: Christian Baker <christian.baker@kcl.ac.uk>
crnbaker
force-pushed
the
1155-savitzky-golay-kernel
branch
from
759daf5 to
4b3345b
Compare
wyli
approved these changes
Jan 15, 2021
Contributor
wyli
left a comment
wyli
left a comment
There was a problem hiding this comment.
thanks! would be great to have the benchmarking notebook in https://github.com/Project-MONAI/tutorials
Contributor
Author
|
Cool I will move it there, thanks for approving! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1155 .
Description
New simplelayer
SavitzkyGolayFilter()applies Savitzky Golay filter to a Tensor along a given axis. New array transformSavitzkyGolaySmooth()usesSavitzkyGolayFilter(). Required change toseparable_filtering()simplelayer: now has option to use padding modes other than 'zeros' during convolution.Example: Smoothing a noisy pulse, result compared to
SciPy.signal.savgol_filter.Performance compared to
SciPy.signal.savgol_filter:Above plots generated using this Google CoLab notebook.
Status
Ready
Types of changes
./runtests.sh --quick.make htmlcommand in thedocs/folder.