Skip to content

Conversation

@deepsource-autofix
Copy link
Contributor

No description provided.

@wyli wyli requested a review from rijobro January 11, 2021 16:49
@wyli
Copy link
Contributor

wyli commented Jan 11, 2021

FYI @rijobro this autofix breaks some of the lazy attribute access in deviceconfig...I'll add some attribute check if needed

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli force-pushed the deepsource-fix-a5f66533 branch from e4efda9 to 0b033d7 Compare January 11, 2021 16:54
@rijobro
Copy link
Contributor

rijobro commented Jan 11, 2021

Sorry, what does it break? I just checked out this PR and ran monai.config.print_debug_info() -- everything looked good to me.

@wyli
Copy link
Contributor

wyli commented Jan 11, 2021

Sorry, what does it break? I just checked out this PR and ran monai.config.print_debug_info() -- everything looked good to me.

I added the workaround, previously the autofix has this issue https://github.com/Project-MONAI/MONAI/runs/1682009836#step:6:10174

@rijobro
Copy link
Contributor

rijobro commented Jan 11, 2021

Ok well the workaround looks good, thanks!

@wyli wyli merged commit 0d59289 into master Jan 11, 2021
@wyli wyli deleted the deepsource-fix-a5f66533 branch January 19, 2021 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants