-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Update occ sens #1430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update occ sens #1430
Conversation
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
wyli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks -- some minor comments in line
|
|
||
| def __call__( # type: ignore | ||
| self, x: torch.Tensor, class_idx: Optional[Union[int, torch.Tensor]] = None, b_box: Optional[Sequence] = None | ||
| self, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought with non-empty class_idx option it'll save some memory here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a marginal increase in memory, the output image might be e.g., 64,64,64,3 instead of 64,64,64 for 3D and even smaller for 2D. Since batch size is always 1, the images will always be small, and it seems a shame to discard the information when it's generated anyway during the inference step at no extra cost.
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
…to update_occ_sens
wyli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Last update to occlusion sensitivity.
Description
@wyli this finally behaves as I expect and I'll upload the tutorials to match.
Now you can:
Status
Ready/Work in progress/Hold
Types of changes
./runtests.sh --codeformat --coverage../runtests.sh --quick.make htmlcommand in thedocs/folder.