Enhance csrc/resample #1471
Merged
Enhance csrc/resample #1471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyli
force-pushed
the
enhance-csrc-resample
branch
2 times, most recently
from
5f4c884 to
b685101
Compare
wyli
force-pushed
the
enhance-csrc-resample
branch
8 times, most recently
from
bbdb85d to
2864f1e
Compare
wyli
force-pushed
the
enhance-csrc-resample
branch
2 times, most recently
from
1797058 to
8398e5d
Compare
Contributor
Author
|
/integration-test /black |
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
wyli
force-pushed
the
enhance-csrc-resample
branch
from
8398e5d to
4eec574
Compare
Contributor
Author
|
this PR is ready for review @rijobro @ericspod @Nic-Ma this is another step towards #789, it mainly includes the latest non-breaking refactoring from https://github.com/balbasty/nitorch/tree/7aba34b7499fe7efe1cfdf12311dfe8d1cf69355/nitorch/_C and added:
the python-based new unit tests should cover most of the cpp/cuda code changes, I'll add more tests in some follow-up PRs as this one is getting large. |
Contributor
Author
rijobro
approved these changes
Feb 24, 2021
Contributor
rijobro
left a comment
rijobro
left a comment
There was a problem hiding this comment.
A little over my head, but the tests look good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
adds tests for csrc/resample, enhancements according to https://github.com/balbasty/nitorch
part of #789
Status
ready
Types of changes
./runtests.sh --codeformat --coverage../runtests.sh --quick.make htmlcommand in thedocs/folder.