Skip to content

Conversation

@IsaacYangSLA
Copy link
Contributor

Stop build if the tag format is wrong

Signed-off-by: Isaac Yang isaacy@nvidia.com

Fixes #1482 .

Description

The dev version of weekly preview build should always be NNMM, where NN is last two digits of YEAR and MM the week number of that year. This is to ensure the format is correct before building and publishing to PyPI.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh --codeformat --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Stop build if the tag format is wrong

Signed-off-by: Isaac Yang <isaacy@nvidia.com>
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@wyli wyli merged commit 2eada01 into Project-MONAI:master Jan 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

weekly build incorrect version number

2 participants