Skip to content

Conversation

@rijobro
Copy link
Contributor

@rijobro rijobro commented Jan 26, 2021

Addresses #1454 (review).

@wyli is this what you had in mind by abstracting out the loss functionality? Whilst this works (and is programmatically cleaner), it's s shame that what was previously achieved in a few lines of code for the end user is now more like 150 (see the extra code added to the test script).

Status

Work in progress

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh --codeformat --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
@rijobro rijobro closed this May 4, 2021
@rijobro rijobro deleted the learning_rate branch May 4, 2021 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant