1533 Fix distributed data parallel issue in ClassificationSaver #1535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge master
Contributor
Author
|
/black |
Signed-off-by: Nic Ma <nma@nvidia.com>
Nic-Ma
force-pushed
the
1533-fix-classificationsaver
branch
from
5597ad9 to
cc53588
Compare
Contributor
Author
|
/black |
Signed-off-by: monai-bot <monai.miccai2019@gmail.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
Contributor
Author
|
/black |
ericspod
reviewed
Feb 2, 2021
ericspod
reviewed
Feb 2, 2021
ericspod
reviewed
Feb 2, 2021
Member
ericspod
left a comment
ericspod
left a comment
There was a problem hiding this comment.
I mentioned some small things only. According to the code coverage output the tests aren't being run under multi GPU with Pytorch 1.7 so string_list_all_gather isn't being tested but it looks ok.
ericspod
approved these changes
Feb 2, 2021
Signed-off-by: Nic Ma <nma@nvidia.com>
Contributor
Author
|
/black |
Nic-Ma
force-pushed
the
1533-fix-classificationsaver
branch
from
5f829f9 to
3b005bd
Compare
Contributor
Author
|
/black |
Signed-off-by: Nic Ma <nma@nvidia.com>
Nic-Ma
force-pushed
the
1533-fix-classificationsaver
branch
from
34e56d9 to
fc08308
Compare
Contributor
Author
|
/black |
Signed-off-by: monai-bot <monai.miccai2019@gmail.com>
Contributor
|
@ericspod the code coverage is inaccurate in our current setting as the multiprocess executions are not tracked properly...I'll create an issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1533 .
Description
This PR fixed the file saving issue of ClassificationSaver in distributed data parallel mode.
Status
Ready
Types of changes
./runtests.sh --codeformat --coverage../runtests.sh --quick.make htmlcommand in thedocs/folder.