Skip to content

Add deepgrow interaction #1582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wyli merged 8 commits into from
Feb 22, 2021
Merged

Add deepgrow interaction #1582

wyli merged 8 commits into from
Feb 22, 2021

Conversation

@YuanTingHsieh
Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh commented Feb 13, 2021 •
edited
Loading

Description

Add deepgrow interaction
This PR is part of the original PR (#1395) with updated tests and docstrings

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh --codeformat --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@YuanTingHsieh
Add deepgrow interaction
2f4db72 
Signed-off-by: YuanTingHsieh <yuantinghsieh@gmail.com>
@SachidanandAlle
Copy link
Contributor

SachidanandAlle commented Feb 15, 2021

LGTM, we can add the reference of original PR #1395 in the description and assign to MONAI developers for final review

wyli
wyli reviewed Feb 18, 2021
View reviewed changes
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks please see some comments inline

@wyli wyli mentioned this pull request Feb 20, 2021
Closed
7 tasks
SachidanandAlle and others added 2 commits February 20, 2021 10:39
@SachidanandAlle
Merge branch 'master' into add_deepgrow_interaction
ae742f9
@SachidanandAlle
Fix review comments
af7794a 
Signed-off-by: Sachidanand Alle <salle@nvidia.com>
wyli
wyli reviewed Feb 20, 2021
View reviewed changes
SachidanandAlle and others added 3 commits February 22, 2021 03:33
@SachidanandAlle
Fix doc
261185c 
Signed-off-by: Sachidanand Alle <salle@nvidia.com>
@SachidanandAlle
Merge branch 'master' into add_deepgrow_interaction
6f8010e
@wyli
fixes docs
7fcfea9 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
Copy link
Contributor

wyli commented Feb 22, 2021

/black

@wyli wyli enabled auto-merge (squash) February 22, 2021 14:14
@wyli wyli merged commit 5dffc11 into Project-MONAI:master Feb 22, 2021
@YuanTingHsieh YuanTingHsieh deleted the add_deepgrow_interaction branch February 27, 2021 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SachidanandAlle SachidanandAlle SachidanandAlle left review comments

@wyli wyli wyli approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@YuanTingHsieh @SachidanandAlle @wyli