Skip to content

Conversation

@Nic-Ma
Copy link
Contributor

@Nic-Ma Nic-Ma commented Mar 9, 2020

Fixes #156 .

Description

This PR updated all the event handlers' API and corresponding examples for arbitrary input format.

Status

Ready

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or new feature that would cause existing functionality to change)
  • New tests added to cover the changes
  • Docstrings/Documentation updated

@Nic-Ma Nic-Ma requested review from atbenmurray, ericspod and wyli March 9, 2020 02:57
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Mar 9, 2020

Hi @wyli ,

Thanks for your review!
I updated code according to the comments, could you please help review it again?
Thanks.

@Nic-Ma Nic-Ma force-pushed the 156-Event-handlers-support-arbitrary-format branch from e36cd71 to c7b3168 Compare March 9, 2020 17:26
@wyli wyli force-pushed the 156-Event-handlers-support-arbitrary-format branch from 07406af to 2a85d9d Compare March 10, 2020 11:59
@wyli wyli merged commit 5c49f8f into master Mar 10, 2020
@wyli wyli deleted the 156-Event-handlers-support-arbitrary-format branch May 21, 2020 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Event-handlers support arbitrary format

3 participants