1575 Add SaveImage and SaveImaged transforms #1612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

wyli merged 11 commits into Project-MONAI:master from Nic-Ma:1575-add-saveimage

Feb 23, 2021

Contributor

Nic-Ma commented Feb 22, 2021

Fixes #1575 .

Description

This PR added the SaveImage and SaveImaged transforms to save data in both pre-transforms and post-transforms.
This can be a useful debugging tool and output tool, like the existing DataStats transform.

Status

Ready

Types of changes

Non-breaking change (fix or new feature that would not break existing functionality).
Breaking change (fix or new feature that would cause existing functionality to change).
New tests added to cover the changes.
Integration tests passed locally by running ./runtests.sh --codeformat --coverage.
Quick tests passed locally by running ./runtests.sh --quick.
In-line docstrings updated.
Documentation updated, tested make html command in the docs/ folder.

Nic-Ma and others added 6 commits

February 1, 2021 19:15


          Merge pull request #19 from Project-MONAI/master

42a45e0

merge master


          [DLMED] add SaveImage and SaveImaged transforms

abac454

Signed-off-by: Nic Ma <nma@nvidia.com>


          Merge branch 'master' into 1575-add-saveimage

94ffea6


          [DLMED] fix typo

6795d65

Signed-off-by: Nic Ma <nma@nvidia.com>


          [DLMED] fix flake8 issues

09e20c4

Signed-off-by: Nic Ma <nma@nvidia.com>


          Merge branch 'master' into 1575-add-saveimage

0919a7d

Nic-Ma requested review from atbenmurray, ericspod and wyli

February 22, 2021 12:13

rijobro reviewed

View reviewed changes

monai/transforms/io/array.py Show resolved Hide resolved


          [DLMED] update according to comments

Signed-off-by: Nic Ma <nma@nvidia.com>

Contributor Author

Nic-Ma commented Feb 22, 2021

/black

rijobro approved these changes

View reviewed changes

Contributor

rijobro left a comment

Looks good!

Nic-Ma added 2 commits

February 23, 2021 00:45


          [DLMED] fix CI tests

1c5199c

Signed-off-by: Nic Ma <nma@nvidia.com>


          Merge branch 'master' into 1575-add-saveimage

b0287b0

Contributor Author

Nic-Ma commented Feb 22, 2021

/black

Nic-Ma enabled auto-merge (squash)

February 22, 2021 17:04

Nic-Ma disabled auto-merge

February 22, 2021 17:04

wyli reviewed

View reviewed changes

monai/data/png_writer.py Outdated Show resolved Hide resolved


          [DLMED] update according to comments

6561fab

Signed-off-by: Nic Ma <nma@nvidia.com>

Contributor Author

Nic-Ma commented Feb 22, 2021

/black


          [DLMED] add ignore

abcd851

Signed-off-by: Nic Ma <nma@nvidia.com>

SachidanandAlle reviewed

View reviewed changes

monai/transforms/io/dictionary.py Show resolved Hide resolved

wyli merged commit a664506 into Project-MONAI:master

Nic-Ma deleted the 1575-add-saveimage branch

July 2, 2021 23:37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet