Skip to content

Conversation

@wyli
Copy link
Contributor

@wyli wyli commented Mar 9, 2020

Fixes #140.

Description

  • adds spacing and orientation transforms
  • revises zoom to do spatial zoom only
  • revises spatialcrop to support spatial ND
  • adds sform qform check for nifti headers
  • adds alias for composables

Status

Ready

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or new feature that would cause existing functionality to change)
  • New tests added to cover the changes
  • Docstrings/Documentation updated

@wyli wyli requested review from Nic-Ma and madil90 March 9, 2020 20:53
@wyli wyli force-pushed the 140-add-image-spacing-orientation-awareness branch 2 times, most recently from 1996d12 to 3caac6d Compare March 10, 2020 01:09
@wyli wyli force-pushed the 140-add-image-spacing-orientation-awareness branch from 3caac6d to 8aa1119 Compare March 10, 2020 02:24
Copy link
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most look good to me except several spellings.

@Nic-Ma Nic-Ma self-requested a review March 10, 2020 06:49
Copy link
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comments inline.

Merge branch 'master' into 140-add-image-spacing-orientation-awareness
@wyli wyli merged commit 35da65c into master Mar 10, 2020
@wyli wyli deleted the 140-add-image-spacing-orientation-awareness branch May 21, 2020 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add image spacing (and maybe orientation) awareness

3 participants