Skip to content

move transforms out of compose file #1623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rijobro merged 9 commits into from
Feb 24, 2021
Merged

move transforms out of compose file #1623

rijobro merged 9 commits into from
Feb 24, 2021

Conversation

@rijobro
Copy link
Contributor

@rijobro rijobro commented Feb 23, 2021 •
edited by wyli
Loading

refactor the Transform, MapTransform and Randomizable to live in transform.py instead of compose.py.

Needed for inverse transform PR.
#1515

@rijobro
move transforms out of compose file
4080b69 
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
@wyli
Copy link
Contributor

wyli commented Feb 23, 2021

this is potentially a breaking change in many cases, could you confirm @Nic-Ma?

@wyli wyli requested a review from Nic-Ma February 23, 2021 15:45
@rijobro
Copy link
Contributor Author

rijobro commented Feb 23, 2021

If it would create many breaking changes, we could always alias the Transform, Randomizable, and MapTransform back into compose.py.

I made these changes because the amount of code in these classes grew so it made sense to put them into their correct file (Transform isn't of type Compose).

I can do without this PR if it's deemed more effort than necessary, but I think it makes things cleaner.

@rijobro
Copy link
Contributor Author

rijobro commented Feb 24, 2021

Hi @wyli @Nic-Ma, backwards compatibility is now supported and tested, see here: https://github.com/Project-MONAI/MONAI/pull/1623/files#diff-5c752a2f5479d567fcd2f5dcaede165633debe9615906cb876fd2d3f552275dbR170-R171.

@rijobro
typo
6f0164b 
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
@rijobro
code format
0684752 
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
wyli
wyli approved these changes Feb 24, 2021
View reviewed changes
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, this is a non-breaking module rearrangement

@rijobro rijobro enabled auto-merge (squash) February 24, 2021 17:57
@rijobro rijobro merged commit 3a1c459 into Project-MONAI:master Feb 24, 2021
@rijobro rijobro deleted the move_transform_out_from_compose branch February 25, 2021 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wyli wyli wyli approved these changes

@Nic-Ma Nic-Ma Awaiting requested review from Nic-Ma

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rijobro @wyli