-
Notifications
You must be signed in to change notification settings - Fork 1.4k
pad_list_data_collate #1626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pad_list_data_collate #1626
Conversation
4b3ab69 to
33798b0
Compare
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
93492a3 to
9715287
Compare
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! maybe we have some issues with the overall utility module arrangements otherwise we wouldn't need the deferred import...please see some comments inline
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
wyli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, this looks nice
A collator, which prior to performing the running collator, pads the images to make sure that sizes match for a given batch.
This is done by calculating the maximum size in each dimension, and then padding all images in the batch to that size.
This introduced a slight circular dependency, because the spatialpadd is now used inside the data level. Solving it required all the seemingly unrelated changes to other files.
#1515