Skip to content

Conversation

@rijobro
Copy link
Contributor

@rijobro rijobro commented Feb 23, 2021

A collator, which prior to performing the running collator, pads the images to make sure that sizes match for a given batch.

This is done by calculating the maximum size in each dimension, and then padding all images in the batch to that size.

This introduced a slight circular dependency, because the spatialpadd is now used inside the data level. Solving it required all the seemingly unrelated changes to other files.

#1515

@rijobro rijobro force-pushed the pad_list_data_collate branch from 4b3ab69 to 33798b0 Compare February 23, 2021 18:51
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
@rijobro rijobro force-pushed the pad_list_data_collate branch from 93492a3 to 9715287 Compare February 24, 2021 13:42
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! maybe we have some issues with the overall utility module arrangements otherwise we wouldn't need the deferred import...please see some comments inline

Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, this looks nice

@wyli wyli enabled auto-merge (squash) February 24, 2021 17:20
@wyli wyli merged commit c98fe05 into Project-MONAI:master Feb 24, 2021
@rijobro rijobro deleted the pad_list_data_collate branch February 25, 2021 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants