Skip to content

Conversation

@Nic-Ma
Copy link
Contributor

@Nic-Ma Nic-Ma commented Mar 1, 2021

Fixes #1668 .

Description

This PR added the RandAxisFlip and RandAxisFlipd transforms.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh --codeformat --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Mar 1, 2021

/black

monai-bot and others added 2 commits March 1, 2021 13:10
Signed-off-by: monai-bot <monai.miccai2019@gmail.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Mar 1, 2021

/black

@wyli
Copy link
Contributor

wyli commented Mar 1, 2021

I think merging this one will create extra work on the existing large PR #1663, perhaps we could hold on a bit here? cc @rijobro @Nic-Ma

@rijobro
Copy link
Contributor

rijobro commented Mar 1, 2021

feel free to merge this and I'll add the inverse to my PR.

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Mar 1, 2021

I think merging this one will create extra work on the existing large PR #1663, perhaps we could hold on a bit here? cc @rijobro @Nic-Ma

Hi @wyli ,

Thanks for raising the concern.
This PR doesn't break any existing logic, and it's a missing transform when we port transforms from Clara to MONAI.
@rijobro , is there any blocker in this PR that may affect your inverse-transform?

Thanks.

Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@wyli wyli enabled auto-merge (squash) March 1, 2021 17:18
@wyli wyli merged commit f5ccdc6 into Project-MONAI:master Mar 1, 2021
@Nic-Ma Nic-Ma deleted the 1668-add-rand-axis-flip branch July 2, 2021 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Need to implement RandAxisFlip transform

4 participants