Skip to content

1673 Add AutoAdjustChannel transform #1675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Nic-Ma merged 13 commits into from
Mar 2, 2021
Merged

1673 Add AutoAdjustChannel transform #1675

Nic-Ma merged 13 commits into from
Mar 2, 2021

Conversation

@Nic-Ma
Copy link
Contributor

@Nic-Ma Nic-Ma commented Mar 2, 2021 •
edited
Loading

Fixes #1673 .

Description

This PR added the AutoAdjustChannel and AutoAdjustChanneld transforms.
Also added more checks and comments for input data shape in image readers.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh --codeformat --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma Nic-Ma mentioned this pull request Mar 2, 2021
Closed
@Nic-Ma
[DLMED] add dict version transform
a98d124 
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Mar 2, 2021

/black

@Nic-Ma Nic-Ma marked this pull request as ready for review March 2, 2021 10:26
@Nic-Ma Nic-Ma changed the title [WIP] 1673 Add AutoAdjustChannel transform 1673 Add AutoAdjustChannel transform Mar 2, 2021
@Nic-Ma Nic-Ma requested review from ericspod, rijobro and wyli March 2, 2021 10:27
monai-bot and others added 2 commits March 2, 2021 10:29
@monai-bot
[MONAI] python code formatting
ffaf8cf 
Signed-off-by: monai-bot <monai.miccai2019@gmail.com>
@Nic-Ma
[DLMED] fix doc-build issue
eefee47 
Signed-off-by: Nic Ma <nma@nvidia.com>
Nic-Ma added 2 commits March 2, 2021 18:59
@Nic-Ma
[DLMED] fix flake8 issue
a109425 
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma
[DLMED] fix flake8 issue
4c4ce9d 
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Mar 2, 2021

/black

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Mar 2, 2021

/black

@Nic-Ma
[DLMED] update doc-strings
7dd4b71 
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma Nic-Ma force-pushed the 1673-add-autoadjustchannel branch from 0dcf9ed to 7dd4b71 Compare March 2, 2021 14:58
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Mar 2, 2021

/black

@monai-bot
[MONAI] python code formatting
9dd2979 
Signed-off-by: monai-bot <monai.miccai2019@gmail.com>
@Nic-Ma Nic-Ma enabled auto-merge (squash) March 2, 2021 15:18
@Nic-Ma Nic-Ma merged commit 9898a89 into Project-MONAI:master Mar 2, 2021
@Nic-Ma Nic-Ma deleted the 1673-add-autoadjustchannel branch July 2, 2021 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rijobro rijobro rijobro approved these changes

@wyli wyli Awaiting requested review from wyli

@ericspod ericspod Awaiting requested review from ericspod

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add AutoAdjustChannel transform

3 participants

@Nic-Ma @rijobro @monai-bot