[1662] Allow missing keys #1676
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
rijobro
commented
Mar 2, 2021
wyli
reviewed
Mar 2, 2021
Contributor
There was a problem hiding this comment.
thanks, I think this a nice direction to go... @jansoe would be great to have your comments as well. I was also thinking of using a special key in keys such as None or * to represent the allow_missing_keys flag... but maybe that's more confusing APIs
jansoe
reviewed
Mar 2, 2021
jansoe
left a comment
jansoe
left a comment
There was a problem hiding this comment.
Very cool, I think this will make pipelines much more flexible.
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
Contributor
|
/black |
wyli
approved these changes
Mar 3, 2021
Contributor
wyli
left a comment
wyli
left a comment
There was a problem hiding this comment.
thank you, it looks good to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1662.
Description
Option to not raise exception if keys are missing during transform.
This is my current proposition. I've only done it for a few classes to get opinions before continuing with rest.
The generator in the base class to minimise code duplication.
Status
Work in progress
Types of changes
./runtests.sh --codeformat --coverage../runtests.sh --quick.make htmlcommand in thedocs/folder.