Skip to content

Conversation

@yiheng-wang-nv
Copy link
Contributor

Signed-off-by: Yiheng Wang vennw@nvidia.com

Fixes #1688 .

Description

Except for the re-implementation of load pre-trained weights function, a new test case is added. For the same input tensor, the output between the torchvision's densenet and our version should be close (since we use nn.Linear for the fc layer, and Cadene's version uses conv layer with kernel size =1, it brings a few difference).

Status

Ready

Types of changes

  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh --codeformat --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@wyli wyli merged commit ac9f953 into Project-MONAI:master Mar 4, 2021
@yiheng-wang-nv yiheng-wang-nv deleted the 1688-fix-senet-pretrain branch March 4, 2021 15:56
KumoLiu added a commit to KumoLiu/MONAI that referenced this pull request Apr 11, 2024
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
KumoLiu added a commit that referenced this pull request Apr 12, 2024
Fixes [tutorial
#1689](Project-MONAI/tutorials#1689)

### Description

Uninstall opencv included in base image.

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Senet pretrained weights issue

2 participants