Skip to content

Conversation

@wyli
Copy link
Contributor

@wyli wyli commented Mar 4, 2021

fixes #1285

Description

  • pycharm 2020 works fine with this pattern
if TYPE_CHECKING:
    from ignite.engine import Engine
    from ignite.metrics import Metric
else:
    Engine, _ = optional_import("ignite.engine", "0.4.2", exact_version, "Engine")
    Metric, _ = optional_import("ignite.metrics", "0.4.2", exact_version, "Metric")
  • this PR adds the missing top-level module list

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli requested review from Nic-Ma and rijobro March 4, 2021 14:13
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
Copy link
Contributor Author

wyli commented Mar 4, 2021

/integration-test

@wyli wyli merged commit 114faf0 into Project-MONAI:master Mar 4, 2021
@wyli wyli deleted the 1285-import branch March 5, 2021 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pycharm can not find declarication to go

2 participants