Skip to content

Conversation

@Nic-Ma
Copy link
Contributor

@Nic-Ma Nic-Ma commented Mar 12, 2020

Fixes #164 #165 .

Description

3D classification training based on dictionary format data and transforms.
3D classification inference based on dictionary format data and transforms.
3D classification inference based on array format data and transforms.
developed ClassificationSaver event handler.
added Resized, Rescaled transforms.
fixed bug in Resize transform that resize by channel dim an updated unit test.
Updated all the APIs in all the examples to the latest version.
Fixed many errors in examples.
Changed UNet output to only logits.
Fixed transform spatial axis issue and updated all unit tests.
Updated all the examples with latest APIs and fixed bugs in examples.

Status

Ready

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or new feature that would cause existing functionality to change)
  • New tests added to cover the changes
  • Docstrings/Documentation updated

@Nic-Ma Nic-Ma requested review from atbenmurray, ericspod and wyli March 12, 2020 16:44
wyli added 2 commits March 13, 2020 00:18
        - unet: num_classes -> out_channels (signature consistency)
        - segmentation demo changed to binary ground truth
        - changed segmentation training dict to have validation every n iterations
        - segmentation demo image sizes to 128, window size to 96, lr 1e-3 (good results)
        - attach classification saver finalize() to Events.COMPLETE
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did some minor edits and I think this PR is ready

@Nic-Ma Nic-Ma force-pushed the 165-update-check-all-examples branch from e24bbf7 to 4229959 Compare March 13, 2020 02:17
@Nic-Ma Nic-Ma merged commit 895e0f2 into master Mar 13, 2020
@wyli wyli deleted the 165-update-check-all-examples branch April 6, 2020 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

develop 3d classification inference example

3 participants