1236 integration test memory #1738
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
rijobro
approved these changes
Mar 10, 2021
Contributor
rijobro
left a comment
rijobro
left a comment
There was a problem hiding this comment.
We should perhaps change nounittests to unittests. As is, we're using a flag to run most checks, and then a flag to not run unit tests. Would be simpler without the double negative.
Contributor
Author
sure, let me revise |
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
wyli
force-pushed
the
update-runtests-sh
branch
from
e849af7 to
099daf0
Compare
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
wyli
force-pushed
the
update-runtests-sh
branch
from
19e8933 to
13df199
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wenqi Li wenqil@nvidia.com
Fixes #1236
fixes #1739
Description
decouples unit tests vs integration tests commands in
runtests.sh,different cuda device indices could be assigned separately for the integration tests
(revised runner default pattern in
runtests.sh./tests/runner.py -p "test_[\!integration]*py")Status
Ready
Types of changes
runtests.sh