Skip to content

Inverse Affined and RandAffined #1781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wyli merged 7 commits into from
Mar 17, 2021
Merged

Inverse Affined and RandAffined #1781

wyli merged 7 commits into from
Mar 17, 2021

Conversation

@rijobro
Copy link
Contributor

@rijobro rijobro commented Mar 16, 2021 •
edited by wyli
Loading

Inverse Affined and RandAffined.
#1515

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

rijobro added 3 commits March 16, 2021 12:11
@rijobro
inverse RandAffined
f22f7c0 
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
@rijobro
undo unintentional change
ff14329 
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
@rijobro
inverse Affined
3b985b3 
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
@rijobro rijobro requested review from Nic-Ma and wyli March 16, 2021 12:51
@rijobro
code format
62bbb21 
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
@rijobro rijobro requested a review from ericspod March 16, 2021 14:59
wyli
wyli approved these changes Mar 17, 2021
View reviewed changes
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps use self.affine instead of the additional return_affine? otherwise looks good

@rijobro
remove return_affine
a3f50e2 
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
@rijobro
Copy link
Contributor Author

rijobro commented Mar 17, 2021

@wyli updated to that effect, thanks.

@rijobro
code format
e2a1dac 
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
@wyli wyli enabled auto-merge (squash) March 17, 2021 16:49
@rijobro rijobro mentioned this pull request Mar 17, 2021
Open
6 tasks
@wyli wyli merged commit 7f0e789 into Project-MONAI:master Mar 17, 2021
rijobro added a commit to rijobro/MONAI that referenced this pull request Mar 18, 2021
@rijobro
Inverse Affined and RandAffined (Project-MONAI#1781)
9e65010 
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
@rijobro rijobro deleted the inverse_Affined branch March 18, 2021 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wyli wyli wyli approved these changes

@Nic-Ma Nic-Ma Awaiting requested review from Nic-Ma

@ericspod ericspod Awaiting requested review from ericspod

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rijobro @wyli