refactor CommonKeys #1825
Merged
refactor CommonKeys #1825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
wyli
approved these changes
Mar 22, 2021
Contributor
Author
|
How is this a breaking change? Do you think many people would be importing CommonKeys in their own code? |
Contributor
|
yes, people are building customised workflows similar to deepgrow https://github.com/Project-MONAI/MONAI/pull/1825/files#diff-41ea322a0a24b98b7e0366343405c3e4e61716b2639f0acbaecea2079e74d127R18 |
Contributor
Author
|
I see. Well at least the old import still works: |
Contributor
|
you're right, this is non-breaking, and we have access to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
CommonKeystoenums.pyso that it can be used by the whole MONAI codebase. Addresses problem in this PR: #1794 (comment).