Skip to content

Conversation

@yiheng-wang-nv
Copy link
Contributor

Signed-off-by: Yiheng Wang vennw@nvidia.com

Fixes #1872 .

Description

The unittest will be added after finishing the code review step.

Status

Work in progress

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Yiheng Wang <vennw@nvidia.com>
@bhashemian bhashemian mentioned this pull request Mar 28, 2021
7 tasks
Copy link
Member

@bhashemian bhashemian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yiheng-wang-nv, thanks for your great work. I realized that this PR needed some design changes that requires the pathology domain knowledge, so I had to take over and reimplement it at #1878.

I am working on the unittests so you don't need to be worry about them.

@yiheng-wang-nv
Copy link
Contributor Author

@yiheng-wang-nv, thanks for your great work. I realized that this PR needed some design changes that requires the pathology domain knowledge, so I had to take over and reimplement it at #1878.

I am working on the unittests so you don't need to be worry about them.

Thanks @behxyz , I closed #1878 and I will review that PR.

@yiheng-wang-nv yiheng-wang-nv deleted the 1872-add-pathology-froc branch March 29, 2021 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Pathology based FROC metric calculation class

2 participants