Fix for Bilateral Filter Backprop #1888
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pass Signed-off-by: chaliebudd <charles.budd@kcl.ac.uk>
7 tasks
Signed-off-by: chaliebudd <charles.budd@kcl.ac.uk>
Signed-off-by: chaliebudd <charles.budd@kcl.ac.uk>
Signed-off-by: chaliebudd <charles.budd@kcl.ac.uk>
wyli
reviewed
Mar 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes Error cause by incorrect use of ctx.save_for_backwards to save non pytorch variable or tensor objects. Changed the code to save parameters as normal attributes of ctx. Also returning None for the gradients of these parameters as they are not currently learnable.
Unit tests have been added to check the backwards function no longer throws errors.
Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests.