Skip to content

Conversation

@bhashemian
Copy link
Member

Description

CuCIM 0.18.2 fixs upside-downed image for TIFF file if the image is not RGB & tiled image with JPEG/Deflate-compressed tiles.

  • Use slow path if the image is not RGB & tiled image with JPEG/Deflate-compressed tiles.
    Show an error message if the out-of-boundary cases are requested with the slow path.
  • ValueError: Cannot handle the out-of-boundary cases for a non-RGB image or a non-Jpeg/Deflate-compressed image.

I have tested it and it works as expected now.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Behrooz <3968947+behxyz@users.noreply.github.com>
@bhashemian bhashemian requested a review from wyli March 31, 2021 19:31
@bhashemian bhashemian enabled auto-merge (squash) March 31, 2021 19:31
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@bhashemian bhashemian merged commit 613f25e into Project-MONAI:master Mar 31, 2021
@bhashemian bhashemian deleted the update_cucim branch April 12, 2021 20:22
nsrivathsa pushed a commit to nsrivathsa/MONAI that referenced this pull request Apr 12, 2021
Signed-off-by: Behrooz <3968947+behxyz@users.noreply.github.com>
Signed-off-by: Neha Srivathsa <nsrivathsa@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants