Skip to content

Update pathology unittests #1910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bhashemian merged 2 commits into from
Mar 31, 2021
Merged

Update pathology unittests #1910

bhashemian merged 2 commits into from
Mar 31, 2021

Conversation

@bhashemian
Copy link
Member

@bhashemian bhashemian commented Mar 31, 2021

Description

This PR prepend "temp_" to all the pathology related test artifacts, including images, tissue masks, probability maps, in order to be easily recognized and ignored in .gitignore

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@bhashemian
Update pathology unittests
4d89402 
Signed-off-by: Behrooz <3968947+behxyz@users.noreply.github.com>
@bhashemian bhashemian requested a review from wyli March 31, 2021 20:01
wyli
wyli approved these changes Mar 31, 2021
View reviewed changes
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@bhashemian bhashemian enabled auto-merge (squash) March 31, 2021 20:09
@bhashemian bhashemian merged commit 5fec791 into Project-MONAI:master Mar 31, 2021
@bhashemian bhashemian deleted the ignore_pathology_test_artifacts branch April 12, 2021 20:22
nsrivathsa pushed a commit to nsrivathsa/MONAI that referenced this pull request Apr 12, 2021
@bhashemian @nsrivathsa
Update pathology unittests (Project-MONAI#1910)
e761433 
Signed-off-by: Behrooz <3968947+behxyz@users.noreply.github.com>
Signed-off-by: Neha Srivathsa <nsrivathsa@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wyli wyli wyli approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bhashemian @wyli