Skip to content

Update prob map handler #1911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bhashemian merged 5 commits into from
Apr 1, 2021
Merged

Update prob map handler #1911

bhashemian merged 5 commits into from
Apr 1, 2021

Conversation

@bhashemian
Copy link
Member

@bhashemian bhashemian commented Mar 31, 2021

Description

This PR makes few improvements to ProbNMS and ProbMapProducer, including renaming and ignoring artifacts.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@bhashemian
Rename the prob map producer unittest to match the module
f093e96 
Signed-off-by: Behrooz <3968947+behxyz@users.noreply.github.com>
@bhashemian
Change probs_map to prob_map
bdd4e7b 
Signed-off-by: Behrooz <3968947+behxyz@users.noreply.github.com>
@bhashemian
Prepend image_inference_outputs with temp to be ignored
e853abc 
Signed-off-by: Behrooz <3968947+behxyz@users.noreply.github.com>
@bhashemian bhashemian requested a review from Nic-Ma March 31, 2021 22:42
@bhashemian bhashemian enabled auto-merge (squash) March 31, 2021 22:42
@bhashemian
Exclude prob map producder handler from min tests
661b2f9 
Signed-off-by: Behrooz <3968947+behxyz@users.noreply.github.com>
@bhashemian bhashemian requested a review from wyli April 1, 2021 02:34
@bhashemian bhashemian merged commit cd3c21a into Project-MONAI:master Apr 1, 2021
@bhashemian bhashemian deleted the update_prob_map_handler branch April 12, 2021 20:22
nsrivathsa pushed a commit to nsrivathsa/MONAI that referenced this pull request Apr 12, 2021
@bhashemian @nsrivathsa
Update prob map handler (Project-MONAI#1911)
71ce959 
* Rename the prob map producer unittest to match the module

Signed-off-by: Behrooz <3968947+behxyz@users.noreply.github.com>

* Change probs_map to prob_map

Signed-off-by: Behrooz <3968947+behxyz@users.noreply.github.com>

* Prepend image_inference_outputs with temp to be ignored

Signed-off-by: Behrooz <3968947+behxyz@users.noreply.github.com>
Signed-off-by: Neha Srivathsa <nsrivathsa@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wyli wyli wyli approved these changes

@Nic-Ma Nic-Ma Awaiting requested review from Nic-Ma

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bhashemian @wyli