Skip to content

Conversation

@kate-sann5100
Copy link
Collaborator

Signed-off-by: kate-sann5100 yiwen.li@st-annes.ox.ac.uk

Fixes # 1868.

Description

Clip variance to be >= 0 to avoid inf in local normalised cross correlation loss.

Status

Ready/Work in progress/Hold

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, looks like a viable workaround for #1868

@wyli wyli enabled auto-merge (squash) April 1, 2021 16:54
@wyli wyli merged commit 32e540f into Project-MONAI:master Apr 1, 2021
nsrivathsa pushed a commit to nsrivathsa/MONAI that referenced this pull request Apr 12, 2021
* clip variance to be >= 0

Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>

* max for torch1.6

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

Co-authored-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Neha Srivathsa <nsrivathsa@nvidia.com>
@wyli wyli mentioned this pull request Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants