Skip to content

Conversation

@Nic-Ma
Copy link
Contributor

@Nic-Ma Nic-Ma commented Apr 2, 2021

Fixes #1900 .

Description

This PR added support to save patch data into nifti or png files.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Nic-Ma and others added 5 commits February 1, 2021 19:15
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Apr 2, 2021

/black

@Nic-Ma Nic-Ma requested review from ericspod, rijobro and wyli April 2, 2021 13:25
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Apr 2, 2021

/black

Nic-Ma and others added 2 commits April 2, 2021 22:24
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible to make patch_index part of the meta_data? I feel image array + meta make more sense than array + meta + patch_index

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Apr 3, 2021

is it possible to make patch_index part of the meta_data? I feel image array + meta make more sense than array + meta + patch_index

In the sample crop, the output data is a list of dict, so I think we should add the index to the dict directly.

Thanks.

@Nic-Ma Nic-Ma merged commit 03b7560 into Project-MONAI:master Apr 3, 2021
nsrivathsa pushed a commit to nsrivathsa/MONAI that referenced this pull request Apr 12, 2021
…MONAI#1922)

* [DLMED] SaveImage supports patch data

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] fix flake8 issue

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] fix flake8 issue

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] fix flake8 issue

Signed-off-by: Nic Ma <nma@nvidia.com>

Co-authored-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Neha Srivathsa <nsrivathsa@nvidia.com>
@Nic-Ma Nic-Ma deleted the 1900-save-batch branch July 2, 2021 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SaveImageD transform need to support list of dict data

2 participants