188 setuptools #193
Merged
188 setuptools #193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
wyli
requested changes
Mar 19, 2020
Contributor
wyli
left a comment
wyli
left a comment
There was a problem hiding this comment.
thanks a lot! for some reason, the ci didn't start for PR from forks, I'll look into that. I put some inline comments based on my local tests.
mhubii
commented
Mar 19, 2020
Contributor
Author
mhubii
left a comment
mhubii
left a comment
There was a problem hiding this comment.
changed contributers, mail, and added empty line to resolve warning
wyli
previously approved these changes
Mar 19, 2020
wyli
reviewed
Mar 19, 2020
README.md
Outdated
|
|
||
| ```bash | ||
| git clone https://github.com/Project-MONAI/MONAI.git | ||
| python setup.py install |
Contributor
There was a problem hiding this comment.
forgot to check this just now, i think we need cd MONAI/ before python setup.py, or pip install -e MONAI/ works fine as well
Contributor
Author
There was a problem hiding this comment.
oh yes you are right
wyli
approved these changes
Mar 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #188
Description