Skip to content

Conversation

@Nic-Ma
Copy link
Contributor

@Nic-Ma Nic-Ma commented Apr 3, 2021

Fixes #1900 .

Description

This PR changed to save the patch_index of every key to the corresponding meta dict.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Apr 3, 2021

/black

@Nic-Ma Nic-Ma requested review from ericspod, rijobro and wyli April 3, 2021 15:03
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Apr 3, 2021

/black

Signed-off-by: monai-bot <monai.miccai2019@gmail.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Apr 3, 2021

/black

@Nic-Ma Nic-Ma enabled auto-merge (squash) April 3, 2021 15:37
@wyli
Copy link
Contributor

wyli commented Apr 3, 2021

/integration-test

@Nic-Ma Nic-Ma merged commit 481f0ce into Project-MONAI:master Apr 3, 2021
nsrivathsa pushed a commit to nsrivathsa/MONAI that referenced this pull request Apr 12, 2021
* [DLMED] change to save patch_index in meta_dict

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] remove error import

Signed-off-by: Nic Ma <nma@nvidia.com>

* [MONAI] python code formatting

Signed-off-by: monai-bot <monai.miccai2019@gmail.com>

* [DLMED] fix CI tests

Signed-off-by: Nic Ma <nma@nvidia.com>

Co-authored-by: monai-bot <monai.miccai2019@gmail.com>
Signed-off-by: Neha Srivathsa <nsrivathsa@nvidia.com>
@Nic-Ma Nic-Ma deleted the 1900-fix-save-patch-issue branch July 2, 2021 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SaveImageD transform need to support list of dict data

3 participants