1943 - fixes ThreadDataLoader #1945
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
ericspod
approved these changes
Apr 5, 2021
Member
ericspod
left a comment
ericspod
left a comment
There was a problem hiding this comment.
Was this a problem with Python 3.6 specifically?
Contributor
Author
|
I've seen this in both 3.6 and 3.7, strangely the unit tests don't capture the error reported in the new threads? |
Member
|
The unittest framework might have issues capturing exceptions on separate threads, we'll have to look into this. I had used this class in Python 3.8 so perhaps something there changed. |
nsrivathsa
pushed a commit
to nsrivathsa/MONAI
that referenced
this pull request
Apr 12, 2021
Signed-off-by: Wenqi Li <wenqil@nvidia.com> Signed-off-by: Neha Srivathsa <nsrivathsa@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wenqi Li wenqil@nvidia.com
Fixes #1943
Status
Ready
Types of changes
./runtests.sh --quick --unittests.