Skip to content

Conversation

@Nic-Ma
Copy link
Contributor

@Nic-Ma Nic-Ma commented Mar 20, 2020

Fixes #191 .

Description

This PR implemented a determinism integration test and fixed several small bugs.

Status

Ready

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or new feature that would cause existing functionality to change)
  • New tests added to cover the changes
  • Docstrings/Documentation updated

@Nic-Ma Nic-Ma requested review from atbenmurray, ericspod and wyli March 20, 2020 03:41
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Mar 20, 2020

@wyli thanks for your review.
I already updated the code according to the comments.
Could you please check it again?
Thanks.

@wyli wyli merged commit d191b09 into master Mar 20, 2020
@wyli wyli deleted the 191-develop-determinism-integration-test branch March 25, 2020 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

develop determinism integration test

3 participants