Skip to content

1956 - docker image building pipelines #1957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wyli merged 6 commits into from
Apr 7, 2021
Merged

1956 - docker image building pipelines #1957

wyli merged 6 commits into from
Apr 7, 2021

Conversation

@wyli
Copy link
Contributor

@wyli wyli commented Apr 6, 2021

Fixes #1956

Description

  • moved docker image related tests to a single yml file
  • the pipeline now generates a static _verion.py via versioneer, copied into the images
  • .git removed from the images, *.md markdown docs included

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • New tests added to cover the changes.

wyli added 5 commits April 6, 2021 20:40
@wyli
refactor docker building
6a3bed8 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
temp tests
3aae361 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
Revert "temp tests"
c672289 
This reverts commit 3aae361.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
remove temp test
6fa1c50 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
temp tests
0fa6b7e 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli requested review from IsaacYangSLA, Nic-Ma and madil90 April 6, 2021 20:04
@wyli wyli marked this pull request as draft April 6, 2021 20:10
@wyli
Revert "temp tests"
9e3c3b1 
This reverts commit 0fa6b7e.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
Copy link
Contributor Author

wyli commented Apr 6, 2021

pipelines verified:

@wyli wyli marked this pull request as ready for review April 6, 2021 20:22
Nic-Ma
Nic-Ma approved these changes Apr 6, 2021
View reviewed changes
Copy link
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good to me, but better to double confirm by @madil90 and @IsaacYangSLA .

Thanks.

@wyli wyli merged commit 5c411d1 into master Apr 7, 2021
@wyli wyli deleted the fixes-dockerfile branch April 7, 2021 00:12
nsrivathsa pushed a commit to nsrivathsa/MONAI that referenced this pull request Apr 12, 2021
@wyli @nsrivathsa
1956 - docker image building pipelines (Project-MONAI#1957)
4456604 
* refactor docker building

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Neha Srivathsa <nsrivathsa@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IsaacYangSLA IsaacYangSLA IsaacYangSLA approved these changes

@Nic-Ma Nic-Ma Nic-Ma approved these changes

@madil90 madil90 Awaiting requested review from madil90

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

.git and versioning in docker image

4 participants

@wyli @IsaacYangSLA @Nic-Ma