Skip to content

Conversation

@bhashemian
Copy link
Member

Description

This PR updates the garbage collection handler's test assertion with more reliable assumptions. It will fixes https://github.com/Project-MONAI/MONAI/runs/2283148095?check_suite_focus=true#step:7:8967

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).

Signed-off-by: Behrooz <3968947+behxyz@users.noreply.github.com>
@bhashemian bhashemian requested a review from wyli April 7, 2021 01:04
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Signed-off-by: Behrooz <3968947+behxyz@users.noreply.github.com>
@wyli wyli enabled auto-merge (squash) April 7, 2021 01:08
@wyli wyli merged commit d6ed956 into Project-MONAI:master Apr 7, 2021
@bhashemian bhashemian deleted the update_garbage_testing branch April 12, 2021 20:22
nsrivathsa pushed a commit to nsrivathsa/MONAI that referenced this pull request Apr 12, 2021
* Update garbage collection assertion to a more reliable one

Signed-off-by: Behrooz <3968947+behxyz@users.noreply.github.com>

* Remove print

Signed-off-by: Behrooz <3968947+behxyz@users.noreply.github.com>
Signed-off-by: Neha Srivathsa <nsrivathsa@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants