-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[WIP] Adding Stain Normalization Transform for Pathology #1998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Neha Srivathsa <nsrivathsa@nvidia.com>
bhashemian
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done, @nsrivathsa! I left few comments inline.
In general, can you think of edge cases in physical world for test cases as well, like the situation that we expect to have only one stain so the concentration of the other one is zero.
Also it would be great to have input images that are not uniformly filled.
Keep in mind that writing solid unittests are very important to ensure the correctness of our code and it might take more time than implementing the original functions and classes.
Signed-off-by: Neha Srivathsa <nsrivathsa@nvidia.com>
Signed-off-by: Neha Srivathsa <nsrivathsa@nvidia.com>
Signed-off-by: Neha Srivathsa <nsrivathsa@nvidia.com>
Signed-off-by: Neha Srivathsa <nsrivathsa@nvidia.com>
Signed-off-by: Neha Srivathsa <nsrivathsa@nvidia.com>
Signed-off-by: Neha Srivathsa <nsrivathsa@nvidia.com>
Signed-off-by: Neha Srivathsa <nsrivathsa@nvidia.com>
Signed-off-by: Neha Srivathsa <nsrivathsa@nvidia.com>
Signed-off-by: Neha Srivathsa <nsrivathsa@nvidia.com>
Signed-off-by: Neha Srivathsa <nsrivathsa@nvidia.com>
|
@nsrivathsa I see that lines 47-75 for stain extraction are being repeated in line 143-171 for stain normalization. Can you modify the code so that it reuses stain extraction in stain normalization? |
Signed-off-by: Neha Srivathsa <nsrivathsa@nvidia.com>
Signed-off-by: Behrooz <3968947+behxyz@users.noreply.github.com>
Signed-off-by: Neha Srivathsa <nsrivathsa@nvidia.com>
Signed-off-by: Behrooz <3968947+behxyz@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+behxyz@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+behxyz@users.noreply.github.com>
… into neha/stain-norm-2
Signed-off-by: Behrooz <3968947+behxyz@users.noreply.github.com>
5294bf2 to
be88f7d
Compare
Signed-off-by: Behrooz <3968947+behxyz@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+behxyz@users.noreply.github.com>
… into neha/stain-norm-2
Signed-off-by: Neha Srivathsa <nsrivathsa@nvidia.com>
|
/build |
|
A variant of this PR is merged. |
Description
Adds a Transform for CuPy-based Stain Normalization for Pathology.
Status
Work in progress
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests.make htmlcommand in thedocs/folder.